Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[network] Use PAL constants in state #877

Merged
merged 1 commit into from
Aug 16, 2023
Merged

[network] Use PAL constants in state #877

merged 1 commit into from
Aug 16, 2023

Conversation

anandbonde
Copy link
Contributor

These contants are important when building on Windows.

@anandbonde anandbonde self-assigned this Aug 15, 2023
iyzhang
iyzhang requested changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you switch this to use Demikernel queue types instead?

ppenna
ppenna approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@ppenna ppenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@anandbonde anandbonde force-pushed the enhancement-use-pal-in-state-machine branch from 9eeaa05 to bd019fb Compare August 16, 2023 19:04
@anandbonde anandbonde merged commit 9462faf into dev Aug 16, 2023
11 checks passed
@anandbonde anandbonde deleted the enhancement-use-pal-in-state-machine branch August 16, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppenna ppenna ppenna approved these changes

@iyzhang iyzhang iyzhang approved these changes

Assignees

@anandbonde anandbonde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anandbonde @ppenna @iyzhang