Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[catnapw] Merge the Catnapw and Catnap LibOSes #918

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

anandbonde
Copy link
Contributor

This PR merges the CatnapW and Catnap LibOSes. This PR also ensures that the tcp (Rust/C) and udp ping-pong examples work on Windows. Once the Windows CI is in place, the build and all the tests will start running for Windows as well.

@anandbonde anandbonde self-assigned this Aug 29, 2023
src/rust/catnap/mod.rs Outdated Show resolved Hide resolved
src/rust/catnap/mod.rs Outdated Show resolved Hide resolved
src/rust/catnap/socket.rs Outdated Show resolved Hide resolved
@ppenna ppenna added the enhancement Enhancement Request on an Existing Feature label Aug 30, 2023
@anandbonde anandbonde force-pushed the enhancement-ab-merge-catnapw-into-catnap branch from 77117c4 to feb8bd0 Compare August 30, 2023 18:02
@anandbonde anandbonde requested a review from ppenna August 30, 2023 18:03
Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this Anand

Copy link
Contributor

@ppenna ppenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern was that I could miss anything from the diff on the sockets layer, but @iyzhang has double checked that.

@anandbonde anandbonde merged commit 811f660 into dev Aug 31, 2023
11 checks passed
@anandbonde anandbonde deleted the enhancement-ab-merge-catnapw-into-catnap branch August 31, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement Request on an Existing Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants