[catmem] Performance counters #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iyzhang
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Thanks for adding this @carvalhof! Should we add this profiler printing to all of our tests? Then we could gather them and display a performance dashboard.
ppenna
reviewed
Aug 30, 2023
|
@carvalhof would you remove the profiling from asynchronous code? Those we want to measure from application side. @iyzhang please jump in if you disagree. |
Done in 6c6f6b7. |
carvalhof
force-pushed
the
enhancement-catmem-profiler
branch
2 times, most recently
from
b854901
to
e297e74
Compare
ppenna
approved these changes
Aug 31, 2023
ppenna
force-pushed
the
enhancement-catmem-profiler
branch
from
e297e74
to
7bb8a9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #894.
Commits: