Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[contrib] Updating Rust Toolchain #922

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Conversation

ppenna
Copy link
Contributor

@ppenna ppenna commented Aug 30, 2023

Description

This PR updates our Rust toolchain to the latest version.

Note that I had to fix the way that we were accessing the socket address data structure. The previous code was generating misaligned accessed and could lead to UB.

@ppenna ppenna added bug Something Isn't Working enhancement Enhancement Request on an Existing Feature labels Aug 30, 2023
@ppenna ppenna self-assigned this Aug 30, 2023
Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppenna ppenna force-pushed the enhancement-contrib-update-toolchain branch from 6e3288f to 6675e0d Compare August 31, 2023 09:24
Copy link
Contributor

@anandbonde anandbonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ppenna ppenna force-pushed the enhancement-contrib-update-toolchain branch from 6675e0d to 6263a46 Compare August 31, 2023 18:29
@ppenna ppenna merged commit fdf4e0f into dev Aug 31, 2023
11 checks passed
@ppenna ppenna deleted the enhancement-contrib-update-toolchain branch August 31, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something Isn't Working enhancement Enhancement Request on an Existing Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants