Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[runtime] Move from generics to dynamic typing for I/O Queue Table #923

Merged
merged 15 commits into from
Sep 5, 2023
Merged

[runtime] Move from generics to dynamic typing for I/O Queue Table #923

merged 15 commits into from
Sep 5, 2023

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented Aug 30, 2023

This PR removes the generics from the IoQueueTable and lets us store queues of various types in the table. This is one step towards having a shared queue table to support multiple libOSes. Since not all of the libOSes have moved to the DemiRuntime, some of the libOSes directly use the queue table, while others go through the DemiRuntime.

@iyzhang iyzhang self-assigned this Aug 30, 2023
@iyzhang iyzhang marked this pull request as ready for review August 31, 2023 00:45
@iyzhang iyzhang force-pushed the wip-irene branch 3 times, most recently from a1dc23a to 026b3a0 Compare August 31, 2023 17:42
@ppenna ppenna self-requested a review September 1, 2023 16:54
@ppenna ppenna added the enhancement Enhancement Request on an Existing Feature label Sep 1, 2023
@ppenna ppenna self-requested a review September 4, 2023 09:55
ppenna
ppenna approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@ppenna ppenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppenna ppenna changed the title [runtime] Enhancement: Move from generics to dynamic typing for I/O Queue Table [runtime] Move from generics to dynamic typing for I/O Queue Table Sep 4, 2023
anandbonde
anandbonde approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@anandbonde anandbonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

iyzhang and others added 15 commits September 5, 2023 13:02
@ppenna ppenna merged commit 575b8e5 into dev Sep 5, 2023
11 checks passed
@ppenna ppenna deleted the wip-irene branch September 5, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppenna ppenna ppenna approved these changes

@anandbonde anandbonde anandbonde approved these changes

Assignees

@iyzhang iyzhang

Labels
enhancement Enhancement Request on an Existing Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iyzhang @anandbonde @ppenna