[catnap] Remove all Rc<RefCell> and replace with SharedObject #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iyzhang
force-pushed
the
enhancement-catnap-remove-rc-refcell
branch
2 times, most recently
from
703e3da
to
6947250
Compare
ppenna
force-pushed
the
enhancement-catnap-remove-rc-refcell
branch
from
6947250
to
06b875e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all of the dynamic borrows in Catnap and replaces them with our new SharedObject abstraction. We rename the shared state objects to SharedCatnapLibOS and SharedCatnapQueue to indicate that they are shared across coroutines.