Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[catloop] Updating task name #932

Merged
merged 1 commit into from
Sep 13, 2023
Merged

[catloop] Updating task name #932

merged 1 commit into from
Sep 13, 2023

Conversation

carvalhof
Copy link
Contributor

This PR updates the names of push and pop coroutines.

iyzhang
iyzhang approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching these!

@iyzhang iyzhang requested a review from ppenna September 11, 2023 18:48
@ppenna ppenna changed the title [catloop]: Enhancement: Updating task name [catloop] Updating task name Sep 13, 2023
@ppenna ppenna self-assigned this Sep 13, 2023
@ppenna ppenna added the enhancement Enhancement Request on an Existing Feature label Sep 13, 2023
ppenna
ppenna approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@ppenna ppenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppenna ppenna merged commit 9937630 into dev Sep 13, 2023
11 checks passed
@ppenna ppenna deleted the enhancement-catloop-typo branch September 13, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppenna ppenna ppenna approved these changes

@iyzhang iyzhang iyzhang approved these changes

Assignees

@ppenna ppenna

Labels
enhancement Enhancement Request on an Existing Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carvalhof @ppenna @iyzhang