Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[runtime] Enhancement: Add Shared to variable name #934

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented Sep 14, 2023

This PR adds Shared to the DemiRuntime to indicate that it is a SharedObject across coroutines.

Copy link
Contributor

@anandbonde anandbonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@ppenna ppenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppenna ppenna added the enhancement Enhancement Request on an Existing Feature label Sep 27, 2023
@ppenna ppenna self-assigned this Sep 27, 2023
@ppenna ppenna merged commit ec29c99 into dev Sep 27, 2023
11 checks passed
@ppenna ppenna deleted the enhancement-runtime-add-explicit-shared-keyword branch September 27, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement Request on an Existing Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants