[demikernel] Localize packing compiler directives for Windows builds #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandbonde
changed the title
anandbonde
force-pushed
the
bugfix-ab-packing-directive-windows
branch
from
68c8960
to
830590e
Compare
iyzhang
approved these changes
Oct 2, 2023
ppenna
force-pushed
the
bugfix-ab-packing-directive-windows
branch
from
830590e
to
1217650
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Localize packing compiler directives for Windows builds. If this is not done, the packing directives will remain active for other build targets as well. So, to avoid this in integration builds (e.g., Bing), localizing the directives is the best option.