[catloop] Warn Backlog Length Listen #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iyzhang you may keep this issue in mind if you were to redesign the connection establishment protocol. |
iyzhang
requested changes
Oct 5, 2023
There was a problem hiding this comment.
Bumping the pending number on accept is not correct because the server is going to dequeue that connection request, not enqueue it, so the pending number does not currently reflect the backlog. In order to reflect the backlog, we would have to increase the pending number when the request arrives in the queue.
iyzhang
approved these changes
Oct 5, 2023
ppenna
force-pushed
the
bugfix-catloop-listen
branch
from
66bde48
to
bbfeaad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #697.
We currently ignore the backlog length and this PR improves existing code by keeping track of pending connections and triggering logging if a passive socket is too busy.
Ideally we would send
ECONNREFUSEDback to clients, but the current connection handshake protocol does not support that. It will keep queueing requests anyways.