[runtime] Remove all Refcell from scheduler #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iyzhang
force-pushed
the
enhancement-runtime-move-scheduler-to-shared-object
branch
3 times, most recently
from
d1d05fc
to
58922c4
Compare
iyzhang
force-pushed
the
enhancement-runtime-move-scheduler-to-shared-object
branch
2 times, most recently
from
4961e52
to
1b511c9
Compare
ppenna
reviewed
Oct 27, 2023
ppenna
force-pushed
the
enhancement-runtime-move-scheduler-to-shared-object
branch
from
1b511c9
to
686b7f6
Compare
ppenna
approved these changes
Oct 27, 2023
ppenna
deleted the
enhancement-runtime-move-scheduler-to-shared-object
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all refcells from the scheduler, as the scheduler is always part of a shared object now and no longer needs to be cloneable.