Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[runtime] Move watched value to current architecture #986

Merged
merged 2 commits into from
Nov 1, 2023
Merged

[runtime] Move watched value to current architecture #986

merged 2 commits into from
Nov 1, 2023

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented Oct 28, 2023

This PR does the following updates for watched value:

  1. Moves to async functions instead of futures
  2. Add support for our shared object abstraction
  3. Removes the use of our intrusive linked list and replaces it with a VecDeque

@iyzhang iyzhang requested a review from ppenna October 28, 2023 12:24
@ppenna ppenna added the enhancement Enhancement Request on an Existing Feature label Oct 30, 2023
@iyzhang iyzhang force-pushed the enhancement-runtime-watched-value branch from a00ca6d to 0529b7e Compare November 1, 2023 15:37
ppenna
ppenna reviewed Nov 1, 2023
View reviewed changes
src/rust/runtime/watched.rs Outdated Show resolved Hide resolved
ppenna
ppenna approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@ppenna ppenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/rust/inetstack/protocols/tcp/established/mod.rs Show resolved Hide resolved
@iyzhang iyzhang force-pushed the enhancement-runtime-watched-value branch from 0529b7e to 6763d24 Compare November 1, 2023 18:22
@iyzhang iyzhang merged commit 75f27d4 into dev Nov 1, 2023
11 checks passed
@iyzhang iyzhang deleted the enhancement-runtime-watched-value branch November 1, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppenna ppenna ppenna approved these changes

Assignees

@iyzhang iyzhang

Labels
enhancement Enhancement Request on an Existing Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iyzhang @ppenna