Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[catcollar] Move to SharedDemiRuntime #991

Merged
merged 3 commits into from
Nov 3, 2023
Merged

[catcollar] Move to SharedDemiRuntime #991

merged 3 commits into from
Nov 3, 2023

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented Nov 2, 2023

This PR does some clean up inside the DemiRuntime needed to move the inetstack to a more object-oriented architecture.

  1. Move to a default constructor. This will let us add more data structures to the shared runtime, like the ephemeral port allocator without adding a lot of new code.
  2. Move Catcollar to the shared runtime. This will let us get rid of the references to the io queue table and scheduler that do not go through the SharedDemiRuntime

@iyzhang iyzhang added the enhancement Enhancement Request on an Existing Feature label Nov 2, 2023
@iyzhang iyzhang self-assigned this Nov 2, 2023
@anandbonde anandbonde self-requested a review November 2, 2023 23:20
anandbonde
anandbonde approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@anandbonde anandbonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@iyzhang iyzhang force-pushed the enhancement-catcollar-shared-runtime branch from 9b87ff2 to 0f89d44 Compare November 3, 2023 17:05
@iyzhang iyzhang merged commit dbd5e25 into dev Nov 3, 2023
10 of 11 checks passed
@iyzhang iyzhang deleted the enhancement-catcollar-shared-runtime branch November 3, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandbonde anandbonde anandbonde approved these changes

Assignees

@iyzhang iyzhang

Labels
enhancement Enhancement Request on an Existing Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iyzhang @anandbonde