Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[runtime] Remove file descriptor from socket id data structure #996

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented Nov 7, 2023

I added a file descriptor to the socket id data structure for demuxing from incoming I/O but it is not platform-agnostic.

@iyzhang iyzhang added the bug Something Isn't Working label Nov 7, 2023
@iyzhang iyzhang self-assigned this Nov 7, 2023
Copy link
Contributor

@anandbonde anandbonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@anandbonde anandbonde merged commit a64cb31 into dev Nov 7, 2023
11 checks passed
@anandbonde anandbonde deleted the bugfix-runtime-remove-fd branch November 7, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something Isn't Working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants