Refactor logger grouping #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waldekmastykarz
force-pushed
the
refactor-logger-grouping-new
branch
from
01aa0cb
to
d59f918
Compare
waldekmastykarz
force-pushed
the
refactor-logger-grouping-new
branch
from
d59f918
to
e7be38e
Compare
garrytrinder
approved these changes
May 22, 2024
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the work from #715 and introduces an update to how our requests are logged. Right now, we print request messages (chaos, mock, etc) as we get them from plugins. With many requests intercepted it makes it hard to understand which messages belong to the same request. This change proposes an update to how we show log messages and groups all messages related to the same request together. Related messages are buffers in a custom formatter, and when it receives the signal that all plugins executed, it prints the collected messages to console.