Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dashboard hang when restoring uninstalled widgets #2256

Merged
merged 3 commits into from Feb 14, 2024

Conversation

krschau
Copy link
Contributor

@krschau krschau commented Feb 13, 2024

Summary of the pull request

PlaceWidget could cause a hang or crash if the widget was deleted and then we tried to update the position via SetPositionCustomStateAsync. This change prevents that crash by only updating state on real widgets, after they are all inserted. PlaceWidget also was a somewhat confusing insertion middleman, and this change removes it entirely and just uses InsertWidgetInPinnedWidgetsAsync instead.

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

@krschau krschau changed the title Fix Dashboard hanging on deleted widgets Fix Dashboard hang when restoring uninstalled widgets Feb 13, 2024
@krschau krschau added the Needs-Second Pull request that needs another approval label Feb 14, 2024
@krschau krschau removed the Needs-Second Pull request that needs another approval label Feb 14, 2024
@krschau krschau merged commit eb5273b into main Feb 14, 2024
4 checks passed
@krschau krschau deleted the user/krschau/deleted-widgets branch February 15, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard doesn't load if widget definitions were deleted
3 participants