Add Hyper-V settings card styled adaptive cards #2489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschau
reviewed
Mar 29, 2024
| { | ||
| "type": "AdaptiveCard", | ||
| "$schema": "http://adaptivecards.io/schemas/adaptive-card.json", | ||
| "version": "1.6", |
There was a problem hiding this comment.
Pretty sure this will refuse to render, you have to make it version 1.5
There was a problem hiding this comment.
Interestingly it renders perfectly with 1.6 still.
…aby/add-hyper-v-code-for-creation-adaptive-cards
3 tasks
…om holding onto items view control internally
…aby/add-hyper-v-code-for-creation-adaptive-cards
dhoehna
approved these changes
Apr 3, 2024
krschau
reviewed
Apr 3, 2024
Comment on lines
+161
to
+170
| { | ||
| { "ImageDescription", GetMergedDescription(image) }, | ||
| { "SubDescription", image.Publisher }, | ||
| { "Header", image.Name }, | ||
| { "HeaderIcon", image.Symbol.Base64Image }, | ||
| { "ActionButtonText", "More info" }, | ||
| { "ContentDialogInfo", SetupContentDialogInfo(image) }, | ||
| { "ButtonToLaunchContentDialogLabel", buttonToLaunchContentDialogLabel }, | ||
| { "SecondaryButtonForContentDialogText", secondaryButtonForContentDialogText }, | ||
| }; |
sshilov7
reviewed
Apr 5, 2024
HyperVExtension/src/HyperVExtension/Models/VMGalleryCreationAdaptiveCardSession.cs
Show resolved
Hide resolved
sshilov7
reviewed
Apr 5, 2024
HyperVExtension/src/HyperVExtension/Models/VMGalleryCreationAdaptiveCardSession.cs
Show resolved
Hide resolved
sshilov7
approved these changes
Apr 5, 2024
3 tasks
bbonaby
changed the base branch from
user/bbonaby-add-adaptive-card-updates2
to
main
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This PR builds off of #2488
It uses the new settings styled adaptive cards introduced in that PR. Please review that one for context. This PR creates the adaptive cards that the Hyper-V extension will send back to dev home once Dev Home requests its creation adaptive cards.
For the UI of how this is rendered see video in #2488
Note: once the above PR goes into the Feature branch I'll retarget this PR to that branch
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist