Announcing the heading group, and repo names. #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhoehna
requested review from
nieubank,
huzaifa-d,
vineeththomasalex,
krschau,
EricJohnson327,
sshilov7,
hart-wilson,
SohamDas2021,
AmelBawa-msft,
bbonaby,
ssparach and
a team
AmelBawa-msft
approved these changes
Mar 29, 2024
| @@ -87,8 +87,8 @@ | |||
| BackgroundSource="{ThemeResource Setup_Banner_Back}" | |||
| OverlaySource="{ThemeResource Setup_Banner_Front}" /> | |||
|
|
|||
| <StackPanel Spacing="{StaticResource SettingsCardSpacing}"> | |||
| <TextBlock Style="{StaticResource SettingsSectionHeaderTextBlockStyle}" x:Uid="ms-resource:///DevHome.SetupFlow/Resources/MainPage_EnvironmentSetup" /> | |||
| <StackPanel Spacing="{StaticResource SettingsCardSpacing}" AutomationProperties.Name="{x:Bind ViewModel.MainPageEnvironmentSetupGroupName}"> | |||
There was a problem hiding this comment.
We can set the automation attributes directly from resw.
<data name="MyStackPanel.[using:Microsoft.UI.Xaml.Automation]AutomationProperties.Name" ...
| @@ -1608,6 +1608,14 @@ | |||
| <value>Loading your environments</value> | |||
| <comment>Test that tells the user that we're still loading their environments. These environments can be virtual or remote machines</comment> | |||
| </data> | |||
| <data name="MainPageEnvironmentSetupGroup" xml:space="preserve"> | |||
| <value>Set up development environment</value> | |||
| <comment>(Narrator reads this entry and should stay in sync with MainPage_EnvironmentSetup.Text ). Header text for a group of controls giving multiple choices to set up the environment/machine</comment> | |||
There was a problem hiding this comment.
Nit
Suggested change
| <comment>(Narrator reads this entry and should stay in sync with MainPage_EnvironmentSetup.Text ). Header text for a group of controls giving multiple choices to set up the environment/machine</comment> | |
| <comment>(Narrator reads this entry and should stay in sync with MainPage_EnvironmentSetup.Text). Header text for a group of controls giving multiple choices to set up the environment/machine</comment> |
vineeththomasalex
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
References and relevant issues
Detailed description of the pull request / Additional comments
Getting narrator to voice the headings was tricky. The automation property needs to be put on the StackPanel encompassing the buttons.
The tricky part is that adding the name property via
x:Uidresults in the narrator saying nothing. I had to put the headings in the ViewModel. A side-effect is that the same string is duplicated.Validation steps performed
PR checklist
Movie!
Narrator.mp4