Change error message in adaptive card for LoginUI failure #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssparach
requested review from
chendrixson,
mathewleeza,
EricJohnson327 and
cinnamon-msft
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mathewleeza
approved these changes
May 12, 2023
| @@ -337,16 +337,6 @@ internal string GetLoginUITemplate(string loginUIState) | |||
| { | |||
| ""type"": ""TextBlock"", | |||
| ""text"": """ + $"{loader.GetString("LoginUI_LoginFailedPage_text2")}" + @""", | |||
| ""text"": ""Make sure your inputs are correct."", | |||
There was a problem hiding this comment.
Yes, the texts shown on the card are localized. This text present here in the adaptivecard json is a bug. The localized version of this text is being removed as part of this PR to improve the error message as well. Thanks!
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the error message on the failing LoginUI per PM suggestions.
Validation
Force replication in debugger to see failure card
Before:
After:
References
ADO item# 44597703