Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build and first project #1

Merged
merged 17 commits into from May 21, 2019
Merged

Add build and first project #1

merged 17 commits into from May 21, 2019

Conversation

javier-alvarez
Copy link
Contributor

@javier-alvarez javier-alvarez commented May 17, 2019 •
edited by MicrosoftHealthService

  • Added basic files and 1 project to initialize the repo

Work item AB#69199

@javier-alvarez javier-alvarez self-assigned this May 20, 2019
@javier-alvarez javier-alvarez added the Build Build related label May 20, 2019
@javier-alvarez javier-alvarez requested a review from a team May 20, 2019 13:01
Richyl2
Richyl2 previously approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@Richyl2 Richyl2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - is it worth adding a test project at this stage?

README.md Outdated Show resolved Hide resolved
src/Microsoft.Health.Dicom.Web/Controllers/ValuesController.cs Outdated Show resolved Hide resolved
src/Microsoft.Health.Dicom.Web/Program.cs Outdated Show resolved Hide resolved
@javier-alvarez javier-alvarez dismissed Richyl2’s stale review May 20, 2019 13:53

Making sure owners approve and it works

@javier-alvarez javier-alvarez requested review from a team and removed request for brendankowitz and johnstairs May 20, 2019 13:54
@javier-alvarez javier-alvarez mentioned this pull request May 20, 2019
Closed
@hansenms hansenms requested a review from johnstairs May 20, 2019 15:50
hansenms
hansenms reviewed May 20, 2019
View reviewed changes
Copy link

@hansenms hansenms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I will let @johnstairs take a look too to get us started. Just a couple of comments:

  • I think we can remove the test auth environment file for now. We can added when we need it.
  • The word resolute should be scrubbed. It is in the nuget.config

README.md Outdated Show resolved Hide resolved
brendankowitz
brendankowitz reviewed May 20, 2019
View reviewed changes
build/.vsts-ci.yml Outdated

name: $(SourceBranchName)-$(Date:yyyyMMdd)$(Rev:-r)

phases:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These have been updated, phases are now jobs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. thanks

johnstairs
johnstairs reviewed May 20, 2019
View reviewed changes
nuget.config Outdated Show resolved Hide resolved
@JoeDRowan
Copy link
Contributor

GeoPol.xml file good @javier-alvarez - Will close pr 2

@JoeDRowan JoeDRowan requested review from JoeDRowan and removed request for JoeDRowan May 21, 2019 11:20
@javier-alvarez javier-alvarez merged commit 4bcdf39 into master May 21, 2019
@jackliums jackliums mentioned this pull request Sep 27, 2019
Closed
@jackliums jackliums deleted the personal/javier-alvarez/initbuild branch March 6, 2020 19:22
jackliums added a commit that referenced this pull request Apr 3, 2020
@jackliums
Refactor #1: UrlResolver and DicomDatasetIdentifier. (#58)
477c733 
Introducing UrlResolver and refactored a few things.
@pengchen0692 pengchen0692 mentioned this pull request Jan 12, 2021
Merged
@npagare npagare mentioned this pull request Mar 27, 2022
Closed
@HitakshiDobariya99 HitakshiDobariya99 mentioned this pull request Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankowitz brendankowitz brendankowitz left review comments

@jmandel jmandel jmandel left review comments

@hansenms hansenms hansenms left review comments

@cunninghamjc cunninghamjc cunninghamjc left review comments

@johnstairs johnstairs johnstairs approved these changes

@Richyl2 Richyl2 Richyl2 left review comments

Assignees
No one assigned
Labels
Build Build related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@javier-alvarez @JoeDRowan @brendankowitz @jmandel @johnstairs @hansenms @Richyl2 @cunninghamjc