Personal/richyl2/metadata blob storage #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tadata-blob-storage
…ion and updated the store handler to read DICOM data
…hat supports fetching attributes
src/Microsoft.Health.Dicom.Metadata/Features/Storage/Models/MetadataExtensions.cs
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Metadata/Features/Storage/Models/MetadataExtensions.cs
Show resolved
Hide resolved
javier-alvarez
approved these changes
Jul 11, 2019
|
@hansenms, @brendankowitz - Ready for review |
hansenms
reviewed
Jul 17, 2019
src/Microsoft.Health.Dicom.Metadata/Features/Storage/Models/MetadataExtensions.cs
Outdated
Show resolved
Hide resolved
|
The use of blob storage for aggregating the data at study, series level worries me a bit. Seems like we are using BLOB storage as a transactional store relying on ETags. I know this is the design, so I am OK with this one. I will let @brendankowitz sign off when he has been through. |
src/Microsoft.Health.Dicom.Core/Features/Persistence/DicomAttributeIdExtensions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Metadata/Features/Storage/DicomMetadataStore.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Metadata/Features/Storage/DicomMetadataStore.cs
Outdated
Show resolved
Hide resolved
...Microsoft.Health.Dicom.Metadata.UnitTests/Features/Storage/Models/DicomStudyMetadataTests.cs
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Metadata/Features/Storage/DicomMetadataStore.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Metadata/Features/Storage/DicomMetadataStore.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Metadata/Features/Storage/DicomMetadataStore.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Metadata/Features/Storage/DicomMetadataStore.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Dicom.Metadata/Features/Storage/Models/DicomSeriesMetadata.cs
Show resolved
Hide resolved
…ctionary and bury the logic of incrementing the index count to the class
brendankowitz
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR is to store metadata in blob storage so results of queries can be served. This work will also keep track of the instances in a series, and the instances in a study, needed to serve the 'retrieve' functionality when the study or series instance identifier is not provided.
Testing