Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmos Indexing Integration #8

Merged
merged 22 commits into from Jul 3, 2019
Merged

Cosmos Indexing Integration #8

merged 22 commits into from Jul 3, 2019

Conversation

Richyl2
Copy link
Contributor

@Richyl2 Richyl2 commented Jun 19, 2019

Description

The purpose of this PR is to add the base framework for indexing DICOM attributes using Cosmos as the backing store.

  • Added new CosmosDb project that implements the IDicomIndexDataStore interface
  • Added configuration to the CosmosDb project that defines which tags should be indexed and surfaced as queryable.

Testing

  • Added new unit test project for the CosmosDb project
  • Added to the integration tests validating all methods and expected exceptions from the index data store

@Richyl2 Richyl2 added the Area-DicomStore STOW-RS label Jun 19, 2019
@Richyl2 Richyl2 marked this pull request as ready for review June 21, 2019 14:37
@Richyl2 Richyl2 requested a review from a team as a code owner June 21, 2019 14:37
Cregganbane
Cregganbane reviewed Jun 24, 2019
View reviewed changes
src/Microsoft.Health.Dicom.Core/Features/Validation/DicomIdentifierValidator.cs Outdated Show resolved Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Persistence/IDicomIndexDataStore.cs Show resolved Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Persistence/IDicomIndexDataStore.cs Outdated Show resolved Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Persistence/IDicomIndexDataStore.cs Outdated Show resolved Hide resolved
src/Microsoft.Health.Dicom.CosmosDb/Features/Storage/Documents/QueryInstance.cs Show resolved Hide resolved
src/Microsoft.Health.Dicom.CosmosDb/Features/Storage/Documents/QueryInstance.cs Show resolved Hide resolved
src/Microsoft.Health.Dicom.CosmosDb/Features/Storage/Documents/QueryInstance.cs Outdated Show resolved Hide resolved
src/Microsoft.Health.Dicom.CosmosDb/Features/Storage/Documents/QueryInstance.cs Outdated Show resolved Hide resolved
src/Microsoft.Health.Dicom.Core/Features/Persistence/IDicomIndexDataStore.cs Outdated Show resolved Hide resolved
@Richyl2
Refactored PR based on comments and added Dicom Attribute for being a…
3d9423e 
…ble to store sequence tags. Updated code to also index fields with a multiplicity greater than 1
@Richyl2
Fixed broken test and resolved more PR comments
01dd8de
@Richyl2
Copy link
Contributor Author

Richyl2 commented Jun 25, 2019

@brandonpollett - Could you take a look at this PR when you get the chance?

@Richyl2 Richyl2 merged commit 10bb6bf into master Jul 3, 2019
@Richyl2 Richyl2 deleted the personal/richyl2/cosmos-storage-integration branch July 22, 2019 10:04
@npagare npagare mentioned this pull request Mar 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansenms hansenms hansenms left review comments

@jackliums jackliums jackliums left review comments

@Cregganbane Cregganbane Cregganbane left review comments

@brendankowitz brendankowitz brendankowitz approved these changes

@javier-alvarez javier-alvarez javier-alvarez approved these changes

Assignees
No one assigned
Labels
Area-DicomStore STOW-RS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Richyl2 @brendankowitz @javier-alvarez @hansenms @jackliums @Cregganbane