Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of DWORD in public interface #44

Closed
walbourn opened this issue Apr 4, 2020 · 2 comments
Closed

Remove use of DWORD in public interface #44

walbourn opened this issue Apr 4, 2020 · 2 comments
Assignees
@walbourn
Labels
maintainence

Comments

@walbourn
Copy link
Member

walbourn commented Apr 4, 2020

I changed most of the functions to take C++ Standard Types, but never fixed up DWORD out of concern for changing link signatures.

I should really change it to something standard.
@walbourn
Copy link
Member Author

Fixed in this commit

@walbourn walbourn self-assigned this May 28, 2020
@walbourn
Copy link
Member Author

walbourn commented May 29, 2020 •
edited

Direct3D already uses a DEFINE_ENUM_FLAG_OPERATORS macro (in winnt.h) to make an enum work as you'd expect for bitmask flags based on recommendations in the C+ standard under 17.5.2.1.3 Bitmask types so I'll go with that.

See also StackOverflow for discussion of the best Modern C++ practice here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@walbourn walbourn

Labels
maintainence
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@walbourn