Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doubts about int64 DXIL support? #34

Closed
oscarbg opened this issue Jan 25, 2017 · 4 comments
Closed

Doubts about int64 DXIL support? #34

oscarbg opened this issue Jan 25, 2017 · 4 comments

Comments

@oscarbg
Copy link

oscarbg commented Jan 25, 2017

Hi,
don't know if it's correct place to ask, but anyway seeing compiler supports int64 in addition to expected wave ops in shader model 6, I'm asking about expected ETA for support for int64?
it's a Shader model 6.0 feature or will be part of Shader model 6.1,6.5,7 or whatever comes nexts..
also will be in creators update coming this spring or will be later shipping like Redstone 3 toward end of the year?
thanks..

@marcelolr
Copy link
Contributor

int64 is supported by shader model 6.0. It's not required of drivers to support this, however - the app should check for feature support before using a shader that uses int64 to create a PSO.

You can see an implementation of the check in the DoesDeviceSupportInt64 function in ExecutionTest.cpp.

OS support is already available in the current previews - you need to be in the Insiders Fast ring to get the build we're currently recommending for running SM6 shaders.

@oscarbg
Copy link
Author

oscarbg commented Jan 26, 2017

Many thanks for pointing the code snippet!
seems Anniv. headers lack this feature option..

Ok so will install new Insiders build coming this week with new game mode announced today (build 15019).. are later builds (like 15019) than the recommended one (15007) ok for testing DXIL&SM6.0?

Also about drivers:
seems Nvidia new 378.49 driver advertises wave ops even on anniversary edition altough showing only SM5.x on Aniversary edition..
do you know if 378.49 supports DXIL and advertises SM6.0 on Insiders builds and is a recommended one for testing DXIL? seems AMD, Intel current public drivers doesn't support SM6.0& DXIL, correct?

Also possibly unrelated question.. seems Creators update brings new driver model WDDM 2.2 is that new driver model needed for support of DXIL& Shader model 6.0 features like Int64 support in drivers or brings graphics improvements unrelated to DXIL..
Thanks..

@jholewinski
Copy link
Collaborator

@oscarbg, Nvidia 378.xx drivers support DXIL in experimental mode (OS in Developer Mode / call D3D12EnableExperimentalFeatures) on Win10 Insider builds.

@marcelolr
Copy link
Contributor

We'll be keeping notes on which driver versions are suitable for bring-up for different features.

One last thing to close this issue out (please open another one if you still have questions). While more recent flights of Windows are still suitable for compiler development, running shaders on WARP may not work correctly - as the code transition from 0.7 to 1.0 support, some things may be broken. We'll update the recommended flight version once 1.0 support is available in WARP (if you don't care for that, feel free to pick any more recent version).

antiagainst pushed a commit to antiagainst/DirectXShaderCompiler that referenced this issue Apr 14, 2017
This change enables CodeGenSPIRV test flow.

New tests can be added by simply adding the test file to
`tools/clang/test/CodeGenSPIRV/` directory and running:

```cpp
TEST_F(WholeFileTest, NewTest) {
  EXPECT_TRUE(runWholeFileTest("new-test-name"));
}
```

The input file with the format described in `WholeFileCheck.h` is read in;
the HLSL portion is passed to the compiler with SPIR-V codegen enabled.
The resulting SPIR-V binary is disassembled and compared to the expected
result in the input file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants