Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use /permissive- for VS 2017 desktop projects #39

Closed
walbourn opened this issue Aug 8, 2018 · 3 comments
Closed

Use /permissive- for VS 2017 desktop projects #39

walbourn opened this issue Aug 8, 2018 · 3 comments

Comments

@walbourn
Copy link
Member

walbourn commented Aug 8, 2018

There is a known issue with the Windows 10 SDK (17134) or earlier when using VS 2017 (15.8 update) and /permissive-. This is fix in a future version of the Windows 10 SDK, so for now I've disabled the usage in this commit

@walbourn
Copy link
Member Author

Workaround remove when upgraded to the Windows 10 SDK (17763) in this commit

@oliver27b
Copy link

hey. i wasn't sure the best way to contact you; this revolves around maintenance for desktop projects.
i was following the tutorial https://github.com/microsoft/DirectXTK12/wiki/Adding-the-DirectX-Tool-Kit
using VS2019 with 10.0.18362.0 and was having problems; NuGet kinda blew up. so i followed the project to project references and it worked. when i started adding headers, some worked, others caused the build to come up with tons of errors. after prodding around a while, i found that if i added
#include "dxgi.h" to my pch.h, everything was happy :) so the tutorial page above if you could let people know they need dxgi.h for some reason (maybe it's supposed to be a header in another file?). anyways i'm kinda new at this so excuse me if this is useless information. thanks

@walbourn
Copy link
Member Author

walbourn commented Nov 20, 2019

@oliver27b - Thanks for the report. It inspired me to add an explicit test to my test suite to validate that all my public headers were including all their dependencies and were 'warnings clean'.

I was indeed missing a includes of DXGI headers in a few cases--all my previous tests, samples, and my tutorial templates include DXGI headers in the pch.h so hadn't noticed the issue before.

See this commit for the details of the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants