-
Notifications
You must be signed in to change notification settings - Fork 124
Conversation
I'd like to see this better match the same scheme that I used for dotnet-docker-samples. We want the minimal directory structure and set of files. Here's my suggestion along those lines:
Here's a simpler Environment block. I'd also suggest removing the ReadLine at the end. I added a WriteLine("**Environment**");
WriteLine($".NET Framework version: {(Environment.Version.Major == 4 ? "4.6.2" : "3.5") } ");
WriteLine($"OS: {Environment.OSVersion}"); We can also remove the namespace from the sample. |
|
<?xml version="1.0" encoding="utf-8"?> | ||
<configuration> | ||
<startup> | ||
<supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.6"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the TFM version to 4.6.2
LGTM |
|
||
if (args.Length > 0) | ||
{ | ||
message = System.String.Join(" ", args); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why System is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 907db09
No description provided.