Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider including Microsoft.VisualStudio.Workload.WebBuildTools in dotnet-framework-build image #60

Closed
samcook opened this issue Dec 7, 2017 · 1 comment

Comments

@samcook
Copy link

samcook commented Dec 7, 2017

Hi

Adding Microsoft.VisualStudio.Workload.WebBuildTools to the vs_BuildTools.exe install command in the dotnet-framework-build image would allow the builder image to be used more easily for publishing web deployments.

e.g.

FROM microsoft/dotnet-framework-build:4.7.1 as builder

WORKDIR /app
COPY . ./
RUN ["nuget.exe", "restore"]
RUN ["msbuild.exe", "Foo.sln", "/p:Configuration=Release", "/p:DeployOnBuild=true", "/p:PublishProfile=Disk"]

FROM microsoft/aspnet:4.7.1
COPY --from=builder /app/published /inetpub/wwwroot
@MichaelSimons
Copy link
Member

@samcook - Yes this is a scenario we plan to support. The current plan is to add a build images within the microsoft/aspnet repo that are based on the microsoft/dotnet-framework-build images. We would like to maintain separation between the two in order to limit the size of the microsoft/dotnet-framework-build images for non-aspnet scenarios. The microsoft/aspnet work is being tracked with microsoft/aspnet-docker#63. We are open to feedback anyone has on the build images. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants