Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Add support for typescript 2.3 #31

Closed
CaselIT opened this issue Apr 28, 2017 · 8 comments
Closed

Add support for typescript 2.3 #31

CaselIT opened this issue Apr 28, 2017 · 8 comments

Comments

@CaselIT
Copy link

CaselIT commented Apr 28, 2017

At the moment dtslint does not support the default generic types introduced in typescript 2.3

This causes pr builds to fail on DefinitelyTyped
Example:
DefinitelyTyped/DefinitelyTyped#16196
DefinitelyTyped/DefinitelyTyped#16198

edit: this is not the the only responsible for build fails on DT, but at the moment it fails when testing locally a package with default generic types

@ghost
Copy link

ghost commented May 1, 2017

We generally wait until a month after a release before changing any packages on DefinitelyTyped. This gives people time to upgrade to the new TypeScript version before packages start requiring it.
Based on that we should enable ts2.3 support on May 27.

@CaselIT
Copy link
Author

CaselIT commented May 1, 2017

Thanks for the info @andy-ms
I was not aware of this practice.
Do you prefer if I close che PR on DT and reopen them in a month time, or should I just leave them open?

@ghost
Copy link

ghost commented May 1, 2017

It's up to you.

@CaselIT
Copy link
Author

CaselIT commented May 1, 2017

Ok, I'll leave them open and reference this issue.

Thanks

@DanielRosenwasser
Copy link
Member

Do we have to have this rule in place across all packages instead of just existing ones? Seems like if a declaration file doesn't exist, there's no reason to keep the restriction in place.

@ghost
Copy link

ghost commented May 2, 2017

That would be nice but the way dtslint is designed, it doesn't distinguish between new/changed packages. I guess we could edit types-publisher to just look for the string // TypeScript Version: 2.3 on changed packages only, and have failures through that instead of dtslint.

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented May 2, 2017

Yes, dtslint just failing on the header is likely confusing to contributors anyway.

@CaselIT
Copy link
Author

CaselIT commented May 4, 2017

Shouldn't this waiting period be implemented in the type publisher?
According to the header it could only update the definition after the month, or alternatively it could publish the updated definition on a next tag in npm and update the latest tag only after a month.
This would avoid a large number of open PR on DT waiting for the end of waiting period and if the next tag is used it would allow users to use the latest definitions if they so choose

I can open a related issue on https://github.com/Microsoft/types-publisher if it's more appropriate

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants