[mongodb] Added support for default generic types

[CaselIT]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

• Increase the version number in the header if appropriate.
• If you are making substantial changes, consider adding a tslint.json containing { "extends": "dslint/dt.json" }.

Added support for default types introduced in ts2.3.
Once microsoft/dtslint#31 is fixed I'll add tslint support when I have time

[dt-bot]

types/mongodb/index.d.ts

to author (@CaselIT). Could you review this PR?
👍 or 👎?

Checklist

• pass the Travis CI test?

[CaselIT]

Waiting for DT to start supporting ts2.3 in about a month. See microsoft/dtslint#31 for details

[hinell]

Don't forget to do the same for AggregationCursor<T>and remove overriding methods of Collection (like find()) that return Cursor<any> and AggregationCursor<any>. They are unnecessary now.

[CaselIT]

You are right, I forgot to update the AggregationCursor. I'll try to do it today. Thanks for the reminder!

[CaselIT]

@yuit I've rebased and resolved the conflict.

@hinell I've updated the find and findOne methods on the collection

[CaselIT]

@andy-ms I'm not sure about the travis fail. It complains about the // TypeScript Version: 2.3 in the header which is present. Do I have to add it to all the packages that reference mongodb?

[ghost]

Yes, if this is breaking other packages they will need a // TypeScript Version: 2.3 comment as well.

[CaselIT]

Thanks. I will add the version header. 👍

[CaselIT]

@andy There seem to be a bug in the types-publisher test.
It finds errors in easy-jsend and express-brute-mongo that do not reference or import any library.
Files: easy-jsend and express-brute-mongo

They do have a reference in the test file. So that may be the cause.Test of easy-jsend Test of express-brute-mongo

[CaselIT]

@andy Let me know if you prefer an issue in the types-publisher repo and adding the // TypeScript Version: 2.3 in easy-jsend and express-brute-mongo in the meantime so this pr can be merged

[ghost]

I don't consider that a bug -- we will test every package using its declared version, and easy-jsend won't compile in ts2.0 any more.
Although since mongodb is mentioned nowhere in the definition of easy-jsend, you could just change the tests to not use it either.

EDIT: Actually, these libraries both seem to really depend on mongodb, but are hastily written and use any where they should be using types from mongodb. It would be great if you could fix them up, otherwise I would add // TypeScript Version: 2.3 comments.

[CaselIT]

Thanks @andy-ms for the feedback
I'll look if I can fix them, otherwise I'll just put // TypeScript Version: 2.3 in the header

[CaselIT]

Should be ok now.
I've fixed the two remaining errors

[ghost]

Thanks!