This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
no-outside-dependencies false positive on 'buffer' #315
Comments
6 tasks
DetachHead
added a commit
to DetachHead/DefinitelyTyped
that referenced
this issue
Jan 2, 2021
8 tasks
This was referenced Oct 19, 2021
alecgibson
added a commit
to alecgibson/DefinitelyTyped
that referenced
this issue
Jan 19, 2022
At the moment, some users' builds fail, because `Blob` isn't defined as a global in Node.js - it sits in the [`buffer`][1] package. This change adds an import from `buffer` to fix this issue. Note that I think the build was incorrectly passing before because of a [leaky interface in `stream/consumers`][2]. Note that I've had to disable the linter's `no-outside-dependencies` because of a [known false positive on `buffer`][3]. [1]: https://nodejs.org/api/buffer.html#class-blob [2]: DefinitelyTyped#55311 (comment) [3]: microsoft/dtslint#315
alecgibson
added a commit
to alecgibson/DefinitelyTyped
that referenced
this issue
Jan 20, 2022
At the moment, some users' builds fail, because `Blob` isn't defined as a global in Node.js - it sits in the [`buffer`][1] package. This change adds an import from `buffer` to fix this issue. Note that I think the build was incorrectly passing before because of a [leaky interface in `stream/consumers`][2]. Note that I've had to disable the linter's `no-outside-dependencies` because of a [known false positive on `buffer`][3]. [1]: https://nodejs.org/api/buffer.html#class-blob [2]: DefinitelyTyped#55311 (comment) [3]: microsoft/dtslint#315
gabritto
pushed a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this issue
Jan 25, 2022
At the moment, some users' builds fail, because `Blob` isn't defined as a global in Node.js - it sits in the [`buffer`][1] package. This change adds an import from `buffer` to fix this issue. Note that I think the build was incorrectly passing before because of a [leaky interface in `stream/consumers`][2]. Note that I've had to disable the linter's `no-outside-dependencies` because of a [known false positive on `buffer`][3]. [1]: https://nodejs.org/api/buffer.html#class-blob [2]: #55311 (comment) [3]: microsoft/dtslint#315
martin-badin
pushed a commit
to martin-badin/DefinitelyTyped
that referenced
this issue
Feb 23, 2022
At the moment, some users' builds fail, because `Blob` isn't defined as a global in Node.js - it sits in the [`buffer`][1] package. This change adds an import from `buffer` to fix this issue. Note that I think the build was incorrectly passing before because of a [leaky interface in `stream/consumers`][2]. Note that I've had to disable the linter's `no-outside-dependencies` because of a [known false positive on `buffer`][3]. [1]: https://nodejs.org/api/buffer.html#class-blob [2]: DefinitelyTyped#55311 (comment) [3]: microsoft/dtslint#315
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
DefinitelyTyped/DefinitelyTyped#49363 (comment)
The text was updated successfully, but these errors were encountered: