Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ticker memory leak #20

Merged
merged 1 commit into from
May 26, 2023
Merged

Fix ticker memory leak #20

merged 1 commit into from
May 26, 2023

Conversation

yaron2
Copy link
Contributor

@yaron2 yaron2 commented May 26, 2023

Discovered when researching dapr/dapr#6399.

@yaron2
fix ticker memory leak
2ad07d8 
Signed-off-by: yaron2 <schneider.yaron@live.com>
cgillum
cgillum approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this fix! I ran some tests using the new Python SDK as well and everything looks good.

@cgillum cgillum merged commit 4486557 into microsoft:main May 26, 2023
3 checks passed
@yaron2 yaron2 deleted the tickerleak-1 branch May 26, 2023 05:47
@cgillum cgillum mentioned this pull request May 26, 2023
Merged
7 tasks
@yaron2 yaron2 mentioned this pull request Jun 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgillum cgillum cgillum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yaron2 @cgillum