Add target based scaling support for MSSQL #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bachuv
commented
May 4, 2023
bachuv
commented
May 4, 2023
cgillum
reviewed
May 5, 2023
| this.TargetScalerDescriptor = new TargetScalerDescriptor(functionId); | ||
| } | ||
|
|
||
| public TargetScalerDescriptor TargetScalerDescriptor { get; private set; } |
There was a problem hiding this comment.
nit: remove the private set to make this a read-only property. You'll still be able to assign it from the constructor.
Merged
13 tasks
cgillum
reviewed
May 21, 2023
| return true; | ||
| } | ||
|
|
||
| #if NETCOREAPP |
There was a problem hiding this comment.
Why do we need the #if NETCOREAPP? Is there any problem if this code exists in both the netstandard2.0 and netcoreapp3.1 targets?
| public class SqlTargetScaler : ITargetScaler | ||
| { | ||
| readonly SqlMetricsProvider sqlMetricsProvider; | ||
| readonly TargetScalerResult scaleResult; |
There was a problem hiding this comment.
Why do we cache the TargetScalerResult object instead of creating a new one for each call?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for target based scaling. It builds upon Azure/azure-functions-durable-extension#2452. This PR is in draft mode since it hasn't been tested E2E yet.
Changes:
SqlMetricsProviderand moveGetMetricsAsync()code fromSqlScaleMonitorhereSqlTargetScaler(implementsITargetScaler)TryGetTargetScalerin SqlDurabilityProvider