Include recursive flag in terminate_orchestration #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
shivamkm07
force-pushed
the
cascade_terminatePurge
branch
from
53af896
to
c3c78b0
Compare
cgillum
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
LGTM. We don't currently run E2E tests as part of the CI. @shivamkm07, is this new test passing locally for you?
Yeah it is passing for me locally |
|
@DeepanshuA can you work with @shivamkm07 to create a release of the Python SDK when necessary? |
Sure |
https://pypi.org/project/durabletask/0.1.1a1/ is now released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds recursive flag in
terminate_orchestrationto support cascade terminate which was added in DTF-Go: microsoft/durabletask-go#47It also updates protos for the same and adds test to verify recursive terminate behavior