Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore bpf_printk in maps.c after https://github.com/vbpf/ebpf-verifier/issues/427 is fixed #1715

Closed
Alan-Jowett opened this issue Dec 6, 2022 · 0 comments · Fixed by #2472
Closed

Restore bpf_printk in maps.c after https://github.com/vbpf/ebpf-verifier/issues/427 is fixed #1715

Alan-Jowett opened this issue Dec 6, 2022 · 0 comments · Fixed by #2472
Assignees
@dthaler
Labels
bug Something isn't working triaged Discussed in a triage meeting
Milestone
2305

Comments

@Alan-Jowett
Copy link
Member

Issue vbpf/ebpf-verifier#427 in the ebpf-verifier repo breaks usage of bpf_printk.

Once it's fixed, revert the thunk in map.c to restore bpf_printk functionality.
@Alan-Jowett Alan-Jowett mentioned this issue Dec 6, 2022
Merged
@Alan-Jowett Alan-Jowett added blocked Blocked on another issue that must be done first triaged Discussed in a triage meeting labels Dec 12, 2022
@Alan-Jowett Alan-Jowett self-assigned this Dec 12, 2022
@Alan-Jowett Alan-Jowett added this to the 2301 milestone Dec 12, 2022
@dthaler dthaler added the bug Something isn't working label Dec 12, 2022
@Alan-Jowett Alan-Jowett modified the milestones: 2301, 2302 Jan 30, 2023
@dthaler dthaler modified the milestones: 2302, 2303 Feb 28, 2023
@dahavey dahavey modified the milestones: 2303, 2304 Mar 20, 2023
@dahavey dahavey modified the milestones: 2304, 2305 Apr 17, 2023
@dahavey dahavey assigned dthaler and unassigned Alan-Jowett May 15, 2023
@dahavey dahavey removed the blocked Blocked on another issue that must be done first label May 15, 2023
dthaler added a commit to dthaler/ebpf-for-windows that referenced this issue May 15, 2023
@dthaler
Revert bpf_printk thunk
df9ba8e 
Fixes microsoft#1715

Signed-off-by: Dave Thaler <dthaler@microsoft.com>
@dthaler dthaler mentioned this issue May 15, 2023
Merged
dthaler added a commit to dthaler/ebpf-for-windows that referenced this issue May 16, 2023
@dthaler
Revert bpf_printk thunk
febc94b 
Fixes microsoft#1715

Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dthaler dthaler

Labels
bug Something isn't working triaged Discussed in a triage meeting
Projects
None yet
Milestone
2305
Development

Successfully merging a pull request may close this issue.

Revert bpf_printk thunk dthaler/ebpf-for-windows
3 participants
@dthaler @Alan-Jowett @dahavey