Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add named parameters to ebpf_tracing.cmd #2372

Closed
gtrevi opened this issue Apr 24, 2023 · 0 comments · Fixed by #2400
Closed

Add named parameters to ebpf_tracing.cmd #2372

gtrevi opened this issue Apr 24, 2023 · 0 comments · Fixed by #2400
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@gtrevi
Copy link
Collaborator

gtrevi commented Apr 24, 2023

Describe the feature you'd like supported

All parameters that are currently hard-coded in the script, will need to be overridable by named parameters.

Proposed solution

Parameters, along with their defaults will be:

  • command (mandatory)
  • trace_path (mandatory)
  • trace_name="ebpf_diag"
  • rundown_period=0:35:00
  • max_file_size_mb=20
  • max_committed_etl_files=30
  • max_committed_wfp_state_files=1

Additional context

This will be a precondition for #2365

@gtrevi gtrevi added the enhancement New feature or request label Apr 24, 2023
@gtrevi gtrevi added this to the 2304 milestone Apr 24, 2023
@gtrevi gtrevi self-assigned this Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant