Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parameters to ebpf_tracing.cmd, revised tracing/cleanup logic #2400

Merged
merged 14 commits into from
Apr 29, 2023

Conversation

gtrevi
Copy link
Collaborator

@gtrevi gtrevi commented Apr 28, 2023

Closes #2372

Description

  • Update the tracing and cleanup logic.
  • Added named parameters to ebpf_tracing.cmd.
  • Parametrized scheduled tasks with newly introduced parameters.

Testing

Local testing: 12h+ with occasional reboots in between (for automatic startup scenario).

Documentation

n.a.

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #2400 (0c2506d) into main (6c02590) will decrease coverage by 1.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2400      +/-   ##
==========================================
- Coverage   85.40%   84.12%   -1.28%     
==========================================
  Files         151      154       +3     
  Lines       28263    28693     +430     
==========================================
  Hits        24137    24137              
- Misses       4126     4556     +430     

see 8 files with indirect coverage changes

@gtrevi gtrevi marked this pull request as ready for review April 28, 2023 05:35
@gtrevi gtrevi changed the title Revised tracing and cleanup logic in ebpf_tracing.cmd Added parameters to ebpf_tracing.cmd, revised tracing/cleanup logic Apr 28, 2023
matthewige
matthewige previously approved these changes Apr 28, 2023
dthaler
dthaler previously approved these changes Apr 28, 2023
@dthaler dthaler added this pull request to the merge queue Apr 28, 2023
@dthaler dthaler added the enhancement New feature or request label Apr 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 28, 2023
saxena-anurag
saxena-anurag previously approved these changes Apr 28, 2023
@saxena-anurag saxena-anurag added this pull request to the merge queue Apr 28, 2023
@gtrevi gtrevi removed this pull request from the merge queue due to a manual request Apr 28, 2023
@gtrevi gtrevi enabled auto-merge April 29, 2023 00:22
@gtrevi gtrevi added this pull request to the merge queue Apr 29, 2023
Merged via the queue into microsoft:main with commit a3cf936 Apr 29, 2023
65 checks passed
@gtrevi gtrevi deleted the gtrevi/trace-script-update branch April 29, 2023 16:05
@gtrevi gtrevi restored the gtrevi/trace-script-update branch April 30, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add named parameters to ebpf_tracing.cmd
4 participants