Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isa-support document is out of date #3025

Closed
dthaler opened this issue Nov 6, 2023 · 0 comments · Fixed by #3069
Closed

isa-support document is out of date #3025

dthaler opened this issue Nov 6, 2023 · 0 comments · Fixed by #3069
Assignees
@dthaler
Labels
bug Something isn't working documentation Improvements or additions to documentation triaged Discussed in a triage meeting
Milestone
2311

Comments

@dthaler
Copy link
Collaborator

dthaler commented Nov 6, 2023 •
edited
Loading

Describe the bug

https://github.com/microsoft/ebpf-for-windows/blob/main/docs/isa-support.rst is missing the cpu=v4 instructions that now appear in
https://www.ietf.org/archive/id/draft-ietf-bpf-isa-00.html

OS information

No response

Steps taken to reproduce bug

Compare the table with the one in the appendix of the Internet Draft

Expected behavior

Rows should match

Actual outcome

Some rows are missing

Additional details

Diffs can be seen at https://author-tools.ietf.org/iddiff?url1=draft-thaler-bpf-isa-02&url2=draft-ietf-bpf-isa-00&difftype=--html
@dthaler dthaler added the bug Something isn't working label Nov 6, 2023
@dthaler dthaler self-assigned this Nov 6, 2023
@dthaler dthaler added the documentation Improvements or additions to documentation label Nov 6, 2023
@dthaler dthaler added this to the 2311 milestone Nov 6, 2023
@Alan-Jowett Alan-Jowett added the triaged Discussed in a triage meeting label Nov 6, 2023
dthaler added a commit to dthaler/ebpf-for-windows that referenced this issue Nov 19, 2023
@dthaler
Update isa-support table
de77ef8 
Match https://github.com/ietf-wg-bpf/ebpf-docs/blob/main/rst/instruction-set-opcodes.rst

Fixes microsoft#3025

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
@dthaler dthaler mentioned this issue Nov 19, 2023
Merged
dthaler added a commit to dthaler/ebpf-for-windows that referenced this issue Nov 19, 2023
@dthaler
Update isa-support table
479eb8a 
Match https://github.com/ietf-wg-bpf/ebpf-docs/blob/main/rst/instruction-set-opcodes.rst

Fixes microsoft#3025

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
dthaler added a commit to dthaler/ebpf-for-windows that referenced this issue Nov 19, 2023
@dthaler
Update isa-support table
0d146aa 
Match https://github.com/ietf-wg-bpf/ebpf-docs/blob/main/rst/instruction-set-opcodes.rst

Fixes microsoft#3025

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
dthaler added a commit to dthaler/ebpf-for-windows that referenced this issue Nov 19, 2023
@dthaler
Update isa-support table
0df0501 
Match https://github.com/ietf-wg-bpf/ebpf-docs/blob/main/rst/instruction-set-opcodes.rst

Fixes microsoft#3025

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
github-merge-queue bot pushed a commit that referenced this issue Nov 27, 2023
@dthaler
Update isa-support table (#3069)
b8edb73 
Match https://github.com/ietf-wg-bpf/ebpf-docs/blob/main/rst/instruction-set-opcodes.rst

Fixes #3025

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dthaler dthaler

Labels
bug Something isn't working documentation Improvements or additions to documentation triaged Discussed in a triage meeting
Projects
None yet
Milestone
2311
Development

Successfully merging a pull request may close this issue.

Update isa-support table dthaler/ebpf-for-windows
2 participants
@dthaler @Alan-Jowett