Code coverage report is calculated before running tests #2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delaramamiri
requested review from
dthaler,
poornagmsft,
Alan-Jowett,
saxena-anurag,
shankarseal,
dv-msft and
gtrevi
as code owners
|
I don't see any code coverage results for this build. How was the number 28 computed? |
saxena-anurag
previously approved these changes
Mar 23, 2023
Codecov Report
@@ Coverage Diff @@
## main #2227 +/- ##
==========================================
- Coverage 83.67% 83.61% -0.06%
==========================================
Files 151 151
Lines 28214 28249 +35
==========================================
+ Hits 23608 23621 +13
- Misses 4606 4628 +22 see 53 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dthaler
previously approved these changes
Mar 25, 2023
Alan-Jowett
approved these changes
Mar 30, 2023
saxena-anurag
previously approved these changes
Mar 30, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
dthaler
previously approved these changes
Mar 31, 2023
dthaler
reviewed
Mar 31, 2023
Alan-Jowett
previously requested changes
Apr 3, 2023
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
saxena-anurag
approved these changes
Apr 4, 2023
dthaler
approved these changes
Apr 4, 2023
Alan-Jowett
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1884
Description
code cov calculates the coverage of tests right before CI/CD build and even running any tests( #1866 (comment)).
This will create confusion whether the coverage change is correct or not. In fact, it computes the numbers before all the tests are complete, which is skewing the numbers.
Testing
Updated the number of
after_n_buildsto reflect the correct threshold. More information about this flag is listed here.Documentation
N/A