Store leaked stacks in memory #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Alan-Jowett
requested review from
dthaler,
poornagmsft,
saxena-anurag,
shankarseal,
dv-msft,
delaramamiri and
gtrevi
as code owners
dv-msft
reviewed
Mar 24, 2023
dv-msft
approved these changes
Mar 24, 2023
Codecov Report
@@ Coverage Diff @@
## main #2232 +/- ##
==========================================
- Coverage 83.67% 83.67% -0.01%
==========================================
Files 151 151
Lines 28214 28223 +9
==========================================
+ Hits 23608 23615 +7
- Misses 4606 4608 +2
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
saxena-anurag
approved these changes
Mar 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Debugging asserts from _ebpf_leak_detector::dump_leaks due to leaked memory is hard as the log is written to the console which is not always captured. To make it easier to debug, this change also writes the log to an in memory buffer.
Testing
CI/CD
Documentation
No.