Simulate NMR API failures: Fix memory leaks and segmentation fault #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shpalani
requested review from
dthaler,
poornagmsft,
Alan-Jowett,
saxena-anurag,
shankarseal,
dv-msft,
delaramamiri and
gtrevi
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2253 +/- ##
==========================================
- Coverage 83.58% 83.58% -0.01%
==========================================
Files 151 151
Lines 28249 28263 +14
==========================================
+ Hits 23613 23623 +10
- Misses 4636 4640 +4
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Alan-Jowett
previously approved these changes
Mar 30, 2023
dthaler
previously approved these changes
Mar 31, 2023
Alan-Jowett
approved these changes
Mar 31, 2023
saxena-anurag
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For each Memory leak call stack and SIGSEGV, please refer to the analysis attached in #2101
This PR was tested with fault injection conditions added for the following NMR APIs.
FYI, Issue #2101 will be addressed in incremental commits.
Testing
Do any existing tests cover this change? Yes
Are new tests needed? No
Documentation
No
Is there any documentation impact for this change?