-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fault Injection in WFP OS APIs #2380
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shpalani
requested review from
dthaler,
poornagmsft,
Alan-Jowett,
saxena-anurag,
shankarseal,
dv-msft,
delaramamiri and
gtrevi
as code owners
April 26, 2023 05:20
dthaler
previously approved these changes
Apr 26, 2023
Alan-Jowett
reviewed
Apr 26, 2023
@shpalani rebase to pick up scorecards fix |
dthaler
reviewed
Apr 26, 2023
dthaler
previously approved these changes
Apr 26, 2023
shpalani
force-pushed
the
shpalan/os-fwp
branch
from
April 26, 2023 23:43
3caad7e
to
7094310
Compare
dthaler
previously approved these changes
Apr 27, 2023
shankarseal
reviewed
Apr 27, 2023
dthaler
approved these changes
Apr 28, 2023
shankarseal
approved these changes
Apr 28, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In net_ebpf_extension_initialize_wfp_components(), added a call to close the session and to unregister the callouts for the failure paths.
Fixed an issue in net_ebpf_extension_initialize_wfp_components(), where the failure status was overwritten with FwpmTransactionAbort() return value and returned as success to the caller. This led the code flow to continue with the assumption that the initialization of wfp components (ie, registering callouts and adding callouts) was successful... This caused assert failure during NmrClientAttachProvider flow.
Note: This is an incremental commit. There are 11 more WFP APIs pending in fwp_um.cpp. Please see #2101 for details.
Testing
_Do any existing tests cover this change? Yes
Are new tests needed? No
Existing test cases with fault injection call stack of 4:
unit_tests.exe: PASSED
netebpfext_unit.exe: PASSED
Documentation
_Is there any documentation impact for this change? No