Harden link state machine #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Alan-Jowett
requested review from
dthaler,
poornagmsft,
saxena-anurag,
shankarseal,
dv-msft,
delaramamiri and
gtrevi
as code owners
dthaler
previously approved these changes
Apr 27, 2023
dthaler
reviewed
Apr 27, 2023
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
dthaler
approved these changes
Apr 27, 2023
dv-msft
reviewed
Apr 27, 2023
| * ATTACHED. When a program is detached from a provider, the state transitions | ||
| * to DETACHING. Once the provider is notified, the state transitions to IDLE. | ||
| * Legal state transitions are: | ||
| * 1. EBPF_LINK_STATE_INITIAL -> EBPF_LINK_STATE_ATTACHING - In ebpf_link_attach_program when the program is being |
There was a problem hiding this comment.
Do we really want to mention the specific (current) functions where this transition is made? Future code changes could make such comments incorrect and thus confusing. IMO, just the part of the comment describing the transition ought to be enough. Thoughts?
dv-msft
reviewed
Apr 27, 2023
| @@ -154,10 +164,23 @@ _ebpf_link_extension_changed_callback( | |||
|
|
|||
| // Complete detach. | |||
| if (provider_data == NULL) { | |||
| // Check if the link is in the process of attaching. | |||
| if (link->state == EBPF_LINK_STATE_DETACHING) { | |||
There was a problem hiding this comment.
The comment above this line mentions 'attaching' but we're checking for detaching? (EBPF_LINK_STATE_DETACHING
There was a problem hiding this comment.
Agreed. Comment is wrong.
dv-msft
reviewed
Apr 27, 2023
dv-msft
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2328
Description
Fix invalid state transitions in link state machine.
Testing
CI/CD + km stress.
Documentation
No.