Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

end_to_end test should have a JIT version of bindmonitor.o #243

Merged
merged 5 commits into from
Jun 22, 2021

Conversation

Alan-Jowett
Copy link
Member

Add a test that JITs the bindmonitor.o eBPF program and runs it.

Blocked on: iovisor/ubpf#78

Resolves: #241

Signed-off-by: Alan Jowett alanjo@microsoft.com

@Alan-Jowett
Copy link
Member Author

Note:
This test currently fails due to bug iovisor/ubpf#78
image

Copy link
Collaborator

@dthaler dthaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok now, I can mark as Approve once I see the test pass

tests/end_to_end/end_to_end.cpp Show resolved Hide resolved
@Alan-Jowett
Copy link
Member Author

When this PR is applied, this test passes:
iovisor/ubpf#78

Will update this PR once the upstream repo takes the fix.

@Alan-Jowett Alan-Jowett marked this pull request as draft June 3, 2021 16:12
@dthaler dthaler changed the title Issue241 end_to_end test should have a JIT version of bindmonitor.o Jun 16, 2021
@dthaler
Copy link
Collaborator

dthaler commented Jun 16, 2021

@Alan-Jowett the uBPF change was merged and this project has been updated to pull it in and this PR was rebased, but the test still seems to fail.

Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
@Alan-Jowett Alan-Jowett marked this pull request as ready for review June 22, 2021 15:34
@Alan-Jowett Alan-Jowett merged commit 562f5ed into microsoft:master Jun 22, 2021
@Alan-Jowett Alan-Jowett deleted the issue241 branch June 28, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

end_to_end test should have a JIT version of bindmonitor.o
2 participants