Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ebpf-for-windows/tools/elfhelper as it is not used anymore. #2590

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Remove ebpf-for-windows/tools/elfhelper as it is not used anymore. #2590

merged 1 commit into from
Jun 13, 2023

Conversation

dv-msft
Copy link
Collaborator

@dv-msft dv-msft commented Jun 12, 2023

Description

The ebpf-for-windows\tools\elfhelper component is not being used (or even built) anymore, so removing it.

Testing

  • ensure clean debug/release builds locally
  • ensure a clean CI/CD pass

Documentation

No doc updates required.

Fixes #2572

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #2590 (d24504d) into main (cc1c6a8) will increase coverage by 38.26%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #2590       +/-   ##
===========================================
+ Coverage   45.72%   83.99%   +38.26%     
===========================================
  Files          57      157      +100     
  Lines        8946    29211    +20265     
===========================================
+ Hits         4091    24536    +20445     
+ Misses       4855     4675      -180     

see 144 files with indirect coverage changes

@dv-msft dv-msft changed the title (DRAFT - NOT FOR REVIEW) - Remove ebpf-for-windows/tools/elfhelper as it is not used anymore. Remove ebpf-for-windows/tools/elfhelper as it is not used anymore. Jun 13, 2023
@dv-msft dv-msft marked this pull request as ready for review June 13, 2023 01:42
@saxena-anurag saxena-anurag added this pull request to the merge queue Jun 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 13, 2023
@dthaler dthaler added this pull request to the merge queue Jun 13, 2023
Merged via the queue into microsoft:main with commit 6e6c817 Jun 13, 2023
84 checks passed
@dv-msft dv-msft deleted the remove-elfhelper branch July 10, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ElfHelper is dead code
3 participants