Implement bpf_get_prandom_u32 using linear congruential generator #2761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Alan-Jowett
requested review from
dthaler,
poornagmsft,
saxena-anurag,
shankarseal,
dv-msft,
delaramamiri,
gtrevi and
shpalani
as code owners
dthaler
previously approved these changes
Aug 16, 2023
saxena-anurag
previously approved these changes
Aug 16, 2023
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Alan-Jowett
dismissed stale reviews from saxena-anurag and dthaler
via
4b85f80
Yes. The cost of the RNG is around 5ns. |
saxena-anurag
previously approved these changes
Aug 16, 2023
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Alan-Jowett
changed the title
saxena-anurag
approved these changes
Aug 17, 2023
dv-msft
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous implementation of bpf_get_prandom_u32 relied on RtlGenRandomEx, which uses a single global state for its PRNG. Replacing this with a per-CPU PRNG implementation.
Testing
CI/CD
Documentation
No.
Installation
No.
Resolves: #2759