Bail if we can't enter rundown in WFP classify callbacks #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3148 +/- ##
==========================================
- Coverage 83.98% 83.97% -0.02%
==========================================
Files 141 141
Lines 26630 26633 +3
==========================================
- Hits 22365 22364 -1
- Misses 4265 4269 +4 ☔ View full report in Codecov by Sentry. |
dv-msft
force-pushed
the
3097-km-stress-test-fix
branch
2 times, most recently
from
156f5b8
to
d417fd4
Compare
dv-msft
changed the title
dv-msft
requested review from
dthaler,
poornagmsft,
Alan-Jowett,
saxena-anurag,
shankarseal,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
shankarseal
reviewed
Jan 5, 2024
dv-msft
force-pushed
the
3097-km-stress-test-fix
branch
from
d417fd4
to
0758a43
Compare
shankarseal
approved these changes
Jan 8, 2024
Alan-Jowett
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In certain instances, inability to enter rundown does not indicate a fatal error. It just means that we lost the race to get there, so we should just exit.
Testing
CI/CD only (Bug cannot be repro'd locally)
Documentation
No doc changes.
Installation
No installer changes.
Fixes #3097