Serialize calls to pe-parse api calls. #3206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dv-msft
force-pushed
the
peparse-serialization-fix
branch
from
e7ed0f5
to
aec4895
Compare
dv-msft
requested review from
dthaler,
poornagmsft,
Alan-Jowett,
saxena-anurag,
shankarseal,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
dthaler
approved these changes
Jan 28, 2024
Alan-Jowett
approved these changes
Jan 29, 2024
saxena-anurag
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR serializes calls to the pe-parse api and the associated error handling by calling them under lock.
Testing
Do any existing tests cover this change? Are new tests needed?
No new tests needed as this is already exercised by the existing multi-threaded stress tests.
Documentation
Is there any documentation impact for this change?
No doc changes required.
Installation
Is there any installer impact for this change?
No installer impact.
Fixes #3207