Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issuing a request having selected Bearer Token authorization but not providing a token fails forever #37

Closed
robpaveza opened this issue Oct 7, 2020 · 0 comments · Fixed by #43
Closed

Issuing a request having selected Bearer Token authorization but not providing a token fails forever #37

robpaveza opened this issue Oct 7, 2020 · 0 comments · Fixed by #43
Labels
bug Something isn't working Iteration-88-1

Comments

@robpaveza
Copy link
Contributor

  1. Select "Bearer Token" authorization
  2. Don't provide a token
  3. Configure the request otherwise
  4. Press 'Send'

Expected: Request issues with a blank Authorization: Bearer header, or request fails with an error message presented to the user.
Actual: Assertion failure in the synthesizeHttpRequest function.
@robpaveza robpaveza added bug Something isn't working Iteration-88-1 labels Oct 7, 2020
robpaveza added a commit that referenced this issue Jan 15, 2021
@robpaveza
Issue #37 - Bearer token assertion causes "forever failure"
cca3ff8
@robpaveza robpaveza linked a pull request Jan 15, 2021 that will close this issue
Accessibility bug sprint #43
Merged
@robpaveza robpaveza mentioned this issue Jan 15, 2021
Merged
robpaveza added a commit that referenced this issue Jan 21, 2021
@robpaveza
Accessibility bug sprint (#43)
846a464 
* MSFT#29924278 / #42 - JSON preview doesn't scroll

* Multiple a11y bugs fixed or started:

 - #29717292 - Can send request when URL field is empty
 - #30134640 - Focus error when going into "Edit Collection
    Authorization" modal dialog (and other dialogs)

* MSFT#30135109: No group, label for radios in Auth and Body

* Combined bug:

 - MSFT#29717285 and #41 - "Save to Collection" action while user
   lacks a Collection in the Host yields a scenario that doesn't make
   sense.

To address this bug, we institute a new frontend-to-host message in
which the frontend causes the host to attempt to ask the user to
create a new Collection, and create a UI affordance for triggering
it.

* Version bump to 0.11.1-preview + a11y bugfixes.

 - Github #46 - Delete operation on grid reorders entries
 - ADO #30152604 - Dialogs do not announce title when presented
 - ADO #30153615 - Show Password label not announced with reader
 - ADO #30135152 - Content-Type dropdown not correctly labeled
 - ADO #30134741 - No success message when deleting a row
 - Github #47 - Focus lost when deleting EditorGrid entries

Additionally for the API surfaces:
 - Introduced `ARIA_ALERT` message
 - Removed `RESTORE_FOCUS` message (changed behavior to restore focus
   to a different control in the frontend component)
 - Exported `serializeParameter` and `serializeEnvironment`

* Self code review

* Issue #37 - Bearer token assertion causes "forever failure"

* Added aria-live to response area - ADO #30152685
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Iteration-88-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Accessibility bug sprint microsoft/edge-devtools-network-console
1 participant
@robpaveza