Addition of custom JSON viewer #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robpaveza
commented
Jan 22, 2021
brcui
approved these changes
Jan 22, 2021
This change introduces a new JSON viewer component. This component is based on the FAST-React `<TreeView>` component with minor modifications (which take place within CSS definitions). It removes the react-json-view component, which cannot be navigated at all with the keyboard.
robpaveza
force-pushed
the
feature/custom-jsonview
branch
from
2750f52
to
e0720eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
react-json-viewpackage, while convenient, was not keyboard- or screen-reader-accessible. This change introduces a custom JSON viewer, powered by the FAST-React<TreeView>control.The easiest way to test this functionality (and the one demonstrated in the picture above) was to retrieve the content from https://petstore.swagger.io/v2/pet/findByStatus?status=sold and storing that in
packages/devtools-network-console/public/dogs.json, running the application vianpm run start, and then enteringdogs.jsonin the URL field and clicking "Send". This allows that file to be downloaded, and the functionality can be tested.