Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the metadata to both Watch and Lease #46

Closed
srz09 opened this issue Oct 20, 2017 · 2 comments
Closed

Give the metadata to both Watch and Lease #46

srz09 opened this issue Oct 20, 2017 · 2 comments

Comments

@srz09
Copy link
Contributor

srz09 commented Oct 20, 2017

I checked your code and you forgot to give the metadata to the Watch client

/* rpc#WatchClient */
watch() {
    return this.client.getConnection('Watch').then(cnx => cnx.client.watch());
}

Should be

/* rpc#WatchClient */
watch() {
    return this.client.getConnection('Watch').then(cnx => cnx.client.watch(cnx.metadata));
}

Same things for LeaseClient#leaseKeepAlive

@srz09
Copy link
Contributor Author

srz09 commented Oct 23, 2017

Will do a PR as soon as the npm run build:proto command will work

@connor4312
Copy link
Member

Fixed in 0.2.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants